Updating Locust to v0.9.0 and using official Dockerfile #7970
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sekka1 If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @sekka1. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-ok-to-test
|
/assign @unguiculus |
| ``` | ||
|
|
||
| | Parameter | Description | Default | | ||
| | ---------------------------- | ---------------------------------- | ----------------------------------------------------- | | ||
| | `Name` | Locust master name | `locust` | | ||
| | 'createTestScripts' | Use Helm to create the test scripts | 'true' | | ||
| | `image.repository` | Locust container image name | `quay.io/honestbee/locust` | | ||
| | `image.tag` | Locust Container image tag | `0.7.5` | |
There was a problem hiding this comment.
update the image tag here as well
There was a problem hiding this comment.
Updated. This will change once Locust.io setups their own docker hub repo. I can update it then. I am following up with them on this here: locustio/locust#850 (comment)
|
@sekka1 please sign the DCO |
Signed-off-by: garland <garlandk@gmail.com>
Signed-off-by: garland <garlandk@gmail.com>
Signed-off-by: garland <garlandk@gmail.com>
Signed-off-by: garland <garlandk@gmail.com>
Signed-off-by: garland <garlandk@gmail.com>
Signed-off-by: garland <garlandk@gmail.com>
Signed-off-by: garland <garlandk@gmail.com>
Signed-off-by: garland <garlandk@gmail.com>
Signed-off-by: garland <garlandk@gmail.com>
Signed-off-by: garland <garlandk@gmail.com>
Signed-off-by: garland <garlandk@gmail.com>
ey-bot
added
the
Contribution Allowed
| nginx.ingress.kubernetes.io/whitelist-source-range: "{{ .Values.ingress.annotations.whitelistSourceRange }}" | ||
| {{ end }} | ||
| spec: | ||
| tls: |
There was a problem hiding this comment.
what happen if i dont want tls?
need to make it configurable
There was a problem hiding this comment.
Good point. Updated to make this configurable.
|
in general, your PR is to update the image and you are adding other things. I would say to make two PRs |
ey-bot
removed
the
Contribution Allowed
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
stale
bot
added
the
lifecycle/stale
What this PR does / why we need it:
This updates Locust to the latest v0.9.0. It also uses the Dockerfile in the Locust Github repo as the standard image.
Which issue this PR fixes
none
Special notes for your reviewer:
Also adds in some features that we have found useful in our testing
Currently it is using the Dockerfile from Locust master branch. They do not have an official Docker Hub repo yet. Trying to get clarification if they are going to do this or not: locustio/locust#850 (comment) .
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
@so0k